Changeset 1938

Timestamp:

Jul 21, 2015 9:50:12 AM (8 years ago)

Author:

vondreele

Message:

H atoms now inserted into Atom list after their attchment (C, N or O)

File:

• trunk/GSASIIphsGUI.py (modified) (7 diffs)

trunk/GSASIIphsGUI.py

@@ -1518 +1518 @@
 
     def OnAtomInsert(event):
-        AtomInsert(0,0,0)
-        FillAtomsGrid(Atoms)
-        event.StopPropagation()
-        G2plt.PlotStructure(G2frame,data)
+        indx = Atoms.GetSelectedRows()
+        if indx:
+            AtomInsert(indx[0],0,0,0)
+            FillAtomsGrid(Atoms)
+            event.StopPropagation()
+            G2plt.PlotStructure(G2frame,data)
         
     def OnAtomViewInsert(event):
@@ -1599 +1601 @@
                     for ineigh,neigh in enumerate(Neigh):
                         AddHydIds[ineigh].append(neigh[2])
+                        loc = AtLookUp[AddHydIds[ineigh][0]]+1
                         if 'O' in neigh[0] and (not len(mapData['rho']) or not 'delt-F' in mapData['MapType']):
                             mapError = True
@@ -1604 +1607 @@
                         Hxyz,HU = G2mth.AddHydrogens(AtLookUp,generalData,atomData,AddHydIds[ineigh])
                         for iX,X in enumerate(Hxyz):
+                            AtomInsert(loc+iX,X[0],X[1],X[2],'H','H(%d)'%(Nat))
+                            data['Atoms'][loc+iX][cia+1] = HU[iX]
+                            Id = data['Atoms'][loc+iX][cia+8]
+                            HydIds[Id] = [iX,AddHydIds[ineigh]]
                             Nat += 1
-                            AtomAdd(X[0],X[1],X[2],'H','H(%d)'%(Nat))
-                            data['Atoms'][-1][cia+1] = HU[iX]
-                            Id = data['Atoms'][-1][cia+8]
-                            HydIds[Id] = [iX,AddHydIds[ineigh]]
+                            AtLookUp = G2mth.FillAtomLookUp(atomData,cia+8)
+                            print Id,HydIds[Id]
                 if mapError:
                     G2frame.ErrorDialog('Add H atom error','Adding O-H atoms requires delt-F map')
@@ -1614 +1619 @@
                 data['General']['HydIds'].update(HydIds)
                 G2frame.dataFrame.AtomEdit.Enable(G2gd.wxID_UPDATEHATOM,True)
+                data['Drawing']['Atoms'] = []
+                UpdateDrawAtoms()
                 FillAtomsGrid(Atoms)
                 dlg.Destroy()
@@ -1633 +1640 @@
             Hxyz,HU = G2mth.AddHydrogens(AtLookUp,generalData,atomData,hydIds[1])
             try:
+                if data['Atoms'][AtLookUp[HId]][ct] != 'H':
+                    raise KeyError
                 data['Atoms'][AtLookUp[HId]][cx:cx+3] = Hxyz[num]
-                data['Atoms'][-1][cia+1] = HU[num]
+                data['Atoms'][AtLookUp[HId]][cia+1] = HU[num]
             except KeyError:
                 delList.append(HId)
                 continue
-        for HId in delList: #clear out deleted H-atoms
+        for HId in delList: #clear out deleted H-atom pointers
             del HydIds[HId]
+        if not len(HydIds):
+            G2frame.dataFrame.AtomEdit.Enable(G2gd.wxID_UPDATEHATOM,False)
         data['Drawing']['Atoms'] = []
         UpdateDrawAtoms()
@@ -1706 +1717 @@
         return atomInfo
         
-    def AtomInsert(x,y,z):
-        indx = Atoms.GetSelectedRows()
-        if indx:
-            indx = indx[0]
-            atomData = data['Atoms']
-            generalData = data['General']
-            Ncol = Atoms.GetNumberCols()
-            E,SGData = G2spc.SpcGroup(generalData['SGData']['SpGrp'])
-            Sytsym,Mult = G2spc.SytSym([0,0,0],SGData)
-            atId = ran.randint(0,sys.maxint)
-            if generalData['Type'] == 'macromolecular':
-                atomData.insert(indx,[0,'UNK','','UNK','UNK','',x,y,z,1,Sytsym,Mult,'I',0.10,0,0,0,0,0,0,atId])
-            elif generalData['Type'] == 'nuclear':
-                atomData.insert(indx,['UNK','UNK','',x,y,z,1,Sytsym,Mult,'I',0.01,0,0,0,0,0,0,atId])
-            elif generalData['Type'] in ['modulated','magnetic']:
-                atomData.insert(indx,['UNK','UNK','',x,y,z,1,Sytsym,Mult,0,'I',0.01,0,0,0,0,0,0,atId,[],[],SSdefault])
-            SetupGeneral()
+    def AtomInsert(indx,x,y,z,El='H',Name='UNK'):
+        atomData = data['Atoms']
+        generalData = data['General']
+        Ncol = Atoms.GetNumberCols()
+        E,SGData = G2spc.SpcGroup(generalData['SGData']['SpGrp'])
+        Sytsym,Mult = G2spc.SytSym([0,0,0],SGData)
+        atId = ran.randint(0,sys.maxint)
+        if generalData['Type'] == 'macromolecular':
+            atomData.insert(indx,[0,Name,'',Name,El,'',x,y,z,1,Sytsym,Mult,'I',0.10,0,0,0,0,0,0,atId])
+        elif generalData['Type'] == 'nuclear':
+            atomData.insert(indx,[Name,El,'',x,y,z,1,Sytsym,Mult,'I',0.01,0,0,0,0,0,0,atId])
+        elif generalData['Type'] in ['modulated','magnetic']:
+            atomData.insert(indx,[Name,El,'',x,y,z,1,Sytsym,Mult,0,'I',0.01,0,0,0,0,0,0,atId,[],[],SSdefault])
+        SetupGeneral()
 
     def AtomDelete(event):
@@ -1740 +1748 @@
                     del atomData[ind]
             if 'Atoms' in data['Drawing']:
+                Atoms.ClearSelection()
                 DrawAtomsDeleteByIDs(IDs)
+                data['Drawing']['Atoms'] = []
+                UpdateDrawAtoms()
                 wx.CallAfter(FillAtomsGrid,Atoms)
                 G2plt.PlotStructure(G2frame,data)